Add peerdns and check_link_down for dynamic interfaces; add logic for… - #75
Merged
Conversation
… blank ipaddress, network, gateway to remove extra entries from ifcfg file; minor lint and comments cleanup
Contributor
Author
|
Re-requested against develop. |
Closed
…g file (bond_dynamic, bond_static)
Contributor
Author
|
I realized that I did not have the updated template logic to handle blank ( '' ) macaddress entries from network_bond_static and network_bond_dynamic without having an empty HWADDR= line. Since I already had the same template patch here for the the other three affected template entries, I did a second commit to add HWADDR. I checked the spec, and I don't think anything there needs updating. Please let me know if you need me either to pull the template changes into a separate pull request (I'd prefer not for the extra work, but I understand why I might need to do that :) ), or if you need me to squash the commits. |
Contributor
Author
|
I just noticed that develop was updated - just let me know if my update here needs to be moved. :) |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… blank ipaddress, network, gateway to remove extra entries from ifcfg file; minor lint and comments cleanup